Commit Graph

4547 Commits

Author SHA1 Message Date
Mike Edmunds
06fb3d9476 Fix: Unifi deploy hook support Unifi Cloud Key (#3327)
* fix: unifi deploy hook also update Cloud Key nginx certs

When running on a Unifi Cloud Key device, also deploy to
/etc/ssl/private/cloudkey.{crt,key} and reload nginx. This
makes the new cert available for the Cloud Key management
app running via nginx on port 443 (as well as the port 8443
Unifi Controller app the deploy hook already supported).

Fixes #3326

* Improve settings documentation comments

* Improve Cloud Key pre-flight error messaging

* Fix typo

* Add support for UnifiOS (Cloud Key Gen2)

Since UnifiOS does not use the Java keystore (like a Unifi
Controller or Cloud Key Gen1 deploy), this also reworks
the settings validation and error messaging somewhat.

* PR review fixes

* Detect unsupported Cloud Key java keystore location

* Don't try to restart inactive services

(and remove extra spaces from reload command)

* Clean up error messages and internal variables

* Change to _getdeployconf/_savedeployconf

* Switch from cp to cat to preserve file permissions
2021-03-21 16:20:32 +01:00
medmunds
fe3e8a7bb6 More than one blank line is an abomination, apparently
I will not try to use whitespace to group code visually
2021-03-21 16:20:32 +01:00
medmunds
ce2ff25edd Implement curl version of smtp notify-hook 2021-03-21 16:20:32 +01:00
medmunds
65a1b892e3 Prep for curl or Python; clean up SMTP_* variable usage 2021-03-21 16:20:32 +01:00
medmunds
e272fde95e Add instructions for reporting bugs 2021-03-21 16:20:32 +01:00
medmunds
d48bff0e20 Only save config if send is successful 2021-03-21 16:20:32 +01:00
medmunds
6e61c34f0f Make shfmt happy
(I'm open to better ways of formatting the heredoc
that embeds the Python script.)
2021-03-21 16:20:32 +01:00
medmunds
2d9506eb54 Implement smtp notify hook
Support notifications via direct SMTP server connection.
Uses Python (2.7.x or 3.4+) to communicate with SMTP server.
2021-03-21 16:20:32 +01:00
jerrm
b1988c7b67 duckdns - fix "integer expression expected" errors (#3397)
* fix "integer expression expected" errors

* duckdns fix

* Update dns_duckdns.sh

* Update dns_duckdns.sh
2021-03-21 16:20:32 +01:00
neilpang
fb5d72c29b upgrade freebsd and solaris 2021-03-21 16:20:32 +01:00
neil
ac148ce0e9 Chain (#3408)
* fix https://github.com/acmesh-official/acme.sh/issues/3384
match the issuer to the root CA cert subject

* fix format

* fix https://github.com/acmesh-official/acme.sh/issues/3384

* remove the alt files. https://github.com/acmesh-official/acme.sh/issues/3384
2021-03-21 16:20:32 +01:00
manuel
016dca654e dnsapi/pdns: also normalize json response in detecting root zone 2021-03-21 16:20:32 +01:00
Gnought
6502bdecbe Updated --preferred-chain to issue ISRG properly
To support different openssl crl2pkcs7 help cli format
2021-03-21 16:20:32 +01:00
Vahid Fardi
91a739af6e change name actor 2021-03-21 16:20:32 +01:00
Vahid Fardi
e232565971 change Author name 2021-03-21 16:20:32 +01:00
Vahid Fardi
472488ebe8 change arvan api script 2021-03-21 16:20:32 +01:00
Alexander Kulumbeg
8de3698b23 Revert "Syncing with the original repo (#2)"
This reverts commit c384ed960c.
2021-03-21 16:16:38 +01:00
neilpang
a694b46914 fix freebsd 2021-03-21 22:46:35 +08:00
Alexander Kulumbeg
c384ed960c
Syncing with the original repo (#2)
* change arvan api script

* change Author name

* change name actor

* Updated --preferred-chain to issue ISRG properly

To support different openssl crl2pkcs7 help cli format

* dnsapi/pdns: also normalize json response in detecting root zone

* Chain (#3408)

* fix https://github.com/acmesh-official/acme.sh/issues/3384
match the issuer to the root CA cert subject

* fix format

* fix https://github.com/acmesh-official/acme.sh/issues/3384

* remove the alt files. https://github.com/acmesh-official/acme.sh/issues/3384

* upgrade freebsd and solaris

* duckdns - fix "integer expression expected" errors (#3397)

* fix "integer expression expected" errors

* duckdns fix

* Update dns_duckdns.sh

* Update dns_duckdns.sh

* Implement smtp notify hook

Support notifications via direct SMTP server connection.
Uses Python (2.7.x or 3.4+) to communicate with SMTP server.

* Make shfmt happy

(I'm open to better ways of formatting the heredoc
that embeds the Python script.)

* Only save config if send is successful

* Add instructions for reporting bugs

* Prep for curl or Python; clean up SMTP_* variable usage

* Implement curl version of smtp notify-hook

* More than one blank line is an abomination, apparently

I will not try to use whitespace to group code visually

* Fix: Unifi deploy hook support Unifi Cloud Key (#3327)

* fix: unifi deploy hook also update Cloud Key nginx certs

When running on a Unifi Cloud Key device, also deploy to
/etc/ssl/private/cloudkey.{crt,key} and reload nginx. This
makes the new cert available for the Cloud Key management
app running via nginx on port 443 (as well as the port 8443
Unifi Controller app the deploy hook already supported).

Fixes #3326

* Improve settings documentation comments

* Improve Cloud Key pre-flight error messaging

* Fix typo

* Add support for UnifiOS (Cloud Key Gen2)

Since UnifiOS does not use the Java keystore (like a Unifi
Controller or Cloud Key Gen1 deploy), this also reworks
the settings validation and error messaging somewhat.

* PR review fixes

* Detect unsupported Cloud Key java keystore location

* Don't try to restart inactive services

(and remove extra spaces from reload command)

* Clean up error messages and internal variables

* Change to _getdeployconf/_savedeployconf

* Switch from cp to cat to preserve file permissions

* feat: add huaweicloud error handling

* fix: fix freebsd and solaris

* support openssl 3.0
fix https://github.com/acmesh-official/acme.sh/issues/3399

* make the fix for rsa key only

* Use PROJECT_NAME and VER for X-Mailer header

Also add X-Mailer header to Python version

* Add _clearaccountconf_mutable()

* Rework read/save config to not save default values

Add and use _readaccountconf_mutable_default and
_saveaccountconf_mutable_default helpers to capture
common default value handling.

New approach also eliminates need for separate
underscore-prefixed version of each conf var.

* Implement _rfc2822_date helper

* Clean email headers and warn on unsupported address format

Just in case, make sure CR or NL don't end up in
an email header.

* Clarify _readaccountconf_mutable_default

* Add Date email header in Python implementation

* Use email.policy.default in Python 3 implementation

Improves standards compatibility and utf-8 handling
in Python 3.3-3.8. (email.policy.default becomes the
default in Python 3.9.)

* Prefer Python to curl when both available

* Change default SMTP_SECURE to "tls"

Secure by default. Also try to minimize configuration errors.
(Many ESPs/ISPs require STARTTLS, and most support it.)

* Update dns_dp.sh

没有encode中文字符会导致提交失败

* No need to include EC parameters explicitly with the private key.
(they are embedded)

* Fixes response handling and thereby allow issuing of subdomain certs

* Adds comment

* fix https://github.com/acmesh-official/acme.sh/issues/3402

* dnsapi/ionos: Use POST instead of PATCH for adding TXT record

The API now supports a POST route for adding records. Therefore
checking for already existing records and including them in a PATCH
request is no longer necessary.

* fix https://github.com/acmesh-official/acme.sh/issues/3433

* fix https://github.com/acmesh-official/acme.sh/issues/3019

* fix format

* Update dns_servercow.sh to support wildcard certs

Updated dns_servercow.sh to support txt records with multiple entries. This supports wildcard certificates that require txt records with the same name and different contents.

* Update dns_servercow.sh to support wildcard certs

Updated dns_servercow.sh to support txt records with multiple entries. This supports wildcard certificates that require txt records with the same name and different contents.

* fix https://github.com/acmesh-official/acme.sh/issues/3312

* fix format

* feat: add dns_porkbun

* fix: prevent rate limit

Co-authored-by: Vahid Fardi <vahid.fardi@snapp.cab>
Co-authored-by: neil <github@neilpang.com>
Co-authored-by: Gnought <1684105+gnought@users.noreply.github.com>
Co-authored-by: manuel <manuel@mausz.at>
Co-authored-by: jerrm <jerrm@users.noreply.github.com>
Co-authored-by: medmunds <medmunds@gmail.com>
Co-authored-by: Mike Edmunds <github@to.mikeedmunds.com>
Co-authored-by: Easton Man <manyang.me@outlook.com>
Co-authored-by: czeming <loser_wind@163.com>
Co-authored-by: Geert Hendrickx <geert@hendrickx.be>
Co-authored-by: Kristian Johansson <kristian.johansson86@gmail.com>
Co-authored-by: Lukas Brocke <lukas@brocke.net>
Co-authored-by: anom-human <80478363+anom-human@users.noreply.github.com>
Co-authored-by: neil <win10@neilpang.com>
Co-authored-by: Quentin Dreyer <quentin.dreyer@rgsystem.com>
2021-03-20 16:01:09 +01:00
Alexander Kulumbeg
2386d2e299
String change 2021-03-20 15:26:32 +01:00
wout
cc7e1a72c1 Retrigger checks 2021-03-14 15:54:28 +01:00
wout
5cc0fa7c98 Retrigger checks 2021-03-14 15:50:16 +01:00
neil
4ce848ab51
Merge pull request #3448 from qkdreyer/dev
Create dns_porkbun.sh
2021-03-14 09:22:18 +08:00
qkdreyer
2e34e11b02 fix: prevent rate limit 2021-03-13 14:53:43 +01:00
Quentin Dreyer
8eda5f36fb feat: add dns_porkbun 2021-03-13 14:25:05 +01:00
neil
3dbe5d872b fix format 2021-03-13 20:46:12 +08:00
neil
96a95ba9fe fix https://github.com/acmesh-official/acme.sh/issues/3312 2021-03-13 20:43:35 +08:00
neil
f594ed659e
Merge pull request #3449 from anom-human/master
Update dns_servercow.sh to support wildcard certs
2021-03-13 20:42:12 +08:00
anom-human
5c4bfbbd95
Update dns_servercow.sh to support wildcard certs
Updated dns_servercow.sh to support txt records with multiple entries. This supports wildcard certificates that require txt records with the same name and different contents.
2021-03-11 20:25:49 +01:00
anom-human
8733635638
Update dns_servercow.sh to support wildcard certs
Updated dns_servercow.sh to support txt records with multiple entries. This supports wildcard certificates that require txt records with the same name and different contents.
2021-03-11 19:11:02 +01:00
wout
928aa74e89 Fix typo 2021-03-10 23:36:34 +01:00
wout
8fdfe673e8 Improve the remove handling so it does not print errors 2021-03-10 23:34:21 +01:00
wout
494a6e6090 Fix checks 2021-03-10 16:32:09 +01:00
wout
89bb7e6b0e Add wildcard certificate support for dns_constellix 2021-03-10 16:18:07 +01:00
neilpang
52cfb9a041 fix format 2021-03-04 21:50:54 +08:00
neilpang
3817ddef41 fix https://github.com/acmesh-official/acme.sh/issues/3019 2021-03-04 21:46:36 +08:00
neilpang
0f494c9dd6 fix https://github.com/acmesh-official/acme.sh/issues/3433 2021-03-01 18:13:50 +08:00
neil
3ff97ecf45
Merge pull request #3430 from lbrocke/dns-api-ionos
dnsapi/ionos: Update API to use POST instead of PATCH for adding TXT records
2021-02-27 11:07:07 +08:00
neil
a10c0b516b
Merge pull request #3426 from jakelamotta/master
Fix issue with subdomain certificates in dns_simply
2021-02-26 22:29:48 +08:00
Lukas Brocke
5eb1469dbf dnsapi/ionos: Use POST instead of PATCH for adding TXT record
The API now supports a POST route for adding records. Therefore
checking for already existing records and including them in a PATCH
request is no longer necessary.
2021-02-26 15:27:22 +01:00
neilpang
9a90fe3794 fix https://github.com/acmesh-official/acme.sh/issues/3402 2021-02-25 07:45:36 +08:00
Kristian Johansson
1917c4b04a Adds comment 2021-02-24 17:34:28 +01:00
neil
2b01d4a203
Merge pull request #3423 from ghen2/dev
No need to include EC parameters explicitly with the private key.
2021-02-24 21:46:09 +08:00
Kristian Johansson
c5100219d1 Fixes response handling and thereby allow issuing of subdomain certs 2021-02-24 08:53:35 +01:00
Geert Hendrickx
a730a08161
No need to include EC parameters explicitly with the private key.
(they are embedded)
2021-02-23 10:28:17 +01:00
F-Plass
4bb8e3a121 Update truenas.sh
-error handling
2021-02-21 22:48:31 +01:00
F-Plass
eacc00f786 Update truenas.sh
- check if curl exists
- check if wget exist, then errortext and exit scipt
- _get command "restartUI"  wirh info about curl error 52
2021-02-21 22:42:24 +01:00
czeming
17f5e557ed
Update dns_dp.sh
没有encode中文字符会导致提交失败
2021-02-20 17:16:33 +08:00
neil
c33e5bc40f
Merge pull request #3416 from acmesh-official/dev
sync
2021-02-19 21:33:44 +08:00
neil
06d1a98ad2
Merge pull request #3330 from medmunds/feature/notify-smtp
Implement smtp notify hook
2021-02-19 09:20:24 +08:00